Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add native filters to Covid Vaccines dashboard #30495

Merged

Conversation

sadpandajoe
Copy link
Member

@sadpandajoe sadpandajoe commented Oct 1, 2024

SUMMARY

None of our current examples dashboards have native filters in them. This will help add one dashboard such that we can test.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link

codecov bot commented Oct 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.91%. Comparing base (76d897e) to head (d328c17).
Report is 822 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #30495       +/-   ##
===========================================
+ Coverage   60.48%   83.91%   +23.43%     
===========================================
  Files        1931      533     -1398     
  Lines       76236    38532    -37704     
  Branches     8568        0     -8568     
===========================================
- Hits        46114    32336    -13778     
+ Misses      28017     6196    -21821     
+ Partials     2105        0     -2105     
Flag Coverage Δ
hive 49.00% <ø> (-0.17%) ⬇️
javascript ?
mysql 76.87% <ø> (?)
postgres 76.94% <ø> (?)
presto 53.50% <ø> (-0.31%) ⬇️
python 83.91% <ø> (+20.43%) ⬆️
sqlite 76.39% <ø> (?)
unit 60.69% <ø> (+3.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sadpandajoe
Copy link
Member Author

/testenv up

Copy link
Contributor

github-actions bot commented Oct 2, 2024

@sadpandajoe Ephemeral environment spinning up at http://54.71.82.134:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@sadpandajoe sadpandajoe marked this pull request as ready for review October 2, 2024 17:00
@dosubot dosubot bot added the dashboard:native-filters Related to the native filters of the Dashboard label Oct 2, 2024
@sadpandajoe sadpandajoe merged commit bd42e33 into apache:master Oct 2, 2024
67 of 68 checks passed
@sadpandajoe sadpandajoe deleted the joe/add-native-filters-to-examples branch October 2, 2024 17:32
Copy link
Contributor

github-actions bot commented Oct 2, 2024

Ephemeral environment shutdown and build artifacts deleted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dashboard:native-filters Related to the native filters of the Dashboard size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants