fix(Jinja metric macro): Support Drill By and Excel/CSV download without a dataset ID #30443
+284
−167
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
The Jinja
{{metric()}}
macro allows you to retrieve the corresponding SQL for a metric by using itskey
, and optionally the dataset ID. When the dataset ID is not specified, it should be automatically retrieved from the context (based on the current dataset).This PR improves the logic to retrieve this value from other places:
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Drill By
BEFORE
AFTER
CSV/Excel Export
BEFORE
AFTER
User prompted to download the file
TESTING INSTRUCTIONS
Tests updated accordingly. For manual testing:
ADDITIONAL INFORMATION