Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't reformat generated queries #30350

Merged
merged 2 commits into from
Oct 4, 2024
Merged

fix: don't reformat generated queries #30350

merged 2 commits into from
Oct 4, 2024

Conversation

betodealmeida
Copy link
Member

SUMMARY

When running a query we pass it through sqlglot to prettify the SQL, but sqlglot is doing some unwanted changes when the dialect is set to generic.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@dosubot dosubot bot added the change:backend Requires changing the backend label Sep 20, 2024
@sadpandajoe sadpandajoe added the v4.1 Label added by the release manager to track PRs to be included in the 4.1 branch label Sep 20, 2024
@betodealmeida betodealmeida force-pushed the remove-query-format branch 4 times, most recently from a9c99eb to 119817f Compare September 20, 2024 19:53
mistercrunch
mistercrunch approved these changes Sep 23, 2024
View reviewed changes
Copy link
Member

@mistercrunch mistercrunch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sadpandajoe sadpandajoe linked an issue Sep 24, 2024 that may be closed by this pull request
Charts fail to load for Trino due to query being updated #30378
Closed
3 tasks
@betodealmeida betodealmeida force-pushed the remove-query-format branch 6 times, most recently from 99e7506 to 4abf432 Compare October 4, 2024 14:22
@betodealmeida betodealmeida merged commit 0b34197 into master Oct 4, 2024
33 checks passed
sadpandajoe pushed a commit that referenced this pull request Oct 4, 2024
@betodealmeida @sadpandajoe
fix: don't reformat generated queries (#30350)
4b9ae07 
(cherry picked from commit 0b34197)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mistercrunch mistercrunch mistercrunch approved these changes

@eschutho eschutho eschutho approved these changes

@jinghua-qa jinghua-qa Awaiting requested review from jinghua-qa jinghua-qa is a code owner

@geido geido Awaiting requested review from geido geido is a code owner

@rusackas rusackas Awaiting requested review from rusackas rusackas is a code owner

Assignees
No one assigned
Labels
change:backend Requires changing the backend size/M v4.1 Label added by the release manager to track PRs to be included in the 4.1 branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Charts fail to load for Trino due to query being updated
4 participants
@betodealmeida @mistercrunch @eschutho @sadpandajoe