-
Notifications
You must be signed in to change notification settings - Fork 13.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(CI): increase node JS heap size #30340
Conversation
After that I feel you should be granted permission to self-approve any PR making these types of changes 🎛️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TO ELEVEN!
Hmmm... one of the OTHER tests is failing, but (thankfully) not the usual native filters tests. Maybe I only turned it up to like 9. Let's see what a couple more GB does... |
That's one of the less frequently flaking tests, and is probably unaffected by extra memory |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, let's hope this makes the Cypress tests less flaky/quicker 👍
I'm actually optimistic about the quicker part... this should use less swap, at least. |
SUMMARY
This is a bit of a shot in the dark, but I saw that some Jest tests were failing due to Javascript running out of heap memory (see screenshot).
My conjecture is that the Native Filter tests we're struggling with are the same issue we're running into here.
So... let's throw a dart at the problem. Apparently, the default size is 1.5GB, so let's go to 4! GPT thinks this'll work for both jest, and the chrome/chromium browser we use in E2E tests, so here goes nothing! Apparently the small GH action runners have 7GB ram, so this seems reasonable-ish.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
If CI passes, we should be good.
ADDITIONAL INFORMATION