Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sdk): use latest @supserset-ui/switchboard version to avoid pulling empty dependency #30217

Merged

Conversation

hainenber
Copy link
Contributor

fix(sdk): use latest @supserset-ui/switchboard version to avoid pulling empty dependency

SUMMARY

Closes #30207
Fix borked @superset-ui/embedded-sdk import caused by @superset-ui/switchboard v0.18.27 published with no compiled codes

image

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

…ng empty dep

Signed-off-by: hainenber <dotronghai96@gmail.com>
@rusackas
Copy link
Member

THANK YOU. The borked release (0.18.27) was my fault. Well, kind of... the release scripts themselves deleted the built assets before publishing them to npm. I think 0.18.26 had the same issue, actually. I have a PR open that will address this, and I'll keep improving (and documenting) the situation once that merges.

@rusackas rusackas merged commit dd4f223 into apache:master Sep 10, 2024
35 of 37 checks passed
@rusackas
Copy link
Member

This fixes the @superset-ui/embedded-sdk codebase, but I guess I'll need to publish that npm package now. Here we go again!

@hainenber hainenber deleted the fix-borked-superset-embedded-sdk-dep branch September 10, 2024 17:41
@mboujaha
Copy link

@rusackas when will the npm package be published ?

@rusackas
Copy link
Member

rusackas commented Sep 10, 2024

Not sure. Edit your package.json for now :)

I need to figure out why the publication scripts aren't publishing that module in the first place, and it's not on my urgent list for the day :)

@mboujaha
Copy link

mboujaha commented Sep 11, 2024

@rusackas we have a ci/cd pipeline which keeps failing because of this issue.
what should we edit in package.json ?
thnx

@DiegoRada
Copy link

Hi @rusackas @mboujaha , I have the same problem, In an application with react and vite when deploying to production you cannot edit the node modules or the package.json (of @superset-ui/embedded-sdk), Did you find any solution for this type of cases?

@mboujaha
Copy link

@DiegoRada the only viable solution that i can think of for automated builds is to edit the package-lock.json

@mboujaha
Copy link

mboujaha commented Sep 12, 2024

@DiegoRada a new version has been published, this should resolve the issue npmjs package

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants