Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Move copying translation files before npm run build in Docker #30099

Merged
merged 5 commits into from
Sep 16, 2024
Merged

fix: Move copying translation files before npm run build in Docker #30099

merged 5 commits into from
Sep 16, 2024

Commits on Sep 12, 2024

  1. Move copying translation files before npm run build in Docker 

    The webpack.config.js now requires that the translation files are present when running the build.
    @martyngigg
    martyngigg committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    c2e41af View commit details
    Browse the repository at this point in the history

  2. Add BUILD_TRANSLATIONS flag to docker build 

    The default build is 'en' only. Unfortunately the translation files need copying
to the image regardless of the flag as COPY cannot be run based on a conditional
    @martyngigg
    martyngigg committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    94495f8 View commit details
    Browse the repository at this point in the history

  3. Add a description of the BUILD_TRANSLATIONS flag 

    to the docker-builds documentation
    @martyngigg
    martyngigg committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    e90fa4c View commit details
    Browse the repository at this point in the history

  4. Skip translations build within lean image if requested

    @martyngigg
    martyngigg committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    c86db91 View commit details
    Browse the repository at this point in the history

  5. Fix linting errors

    @martyngigg
    martyngigg committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    d6c9237 View commit details
    Browse the repository at this point in the history