Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stabilizing Celery / SQL Lab #2981

Merged
merged 1 commit into from
Jun 20, 2017
Merged

Stabilizing Celery / SQL Lab #2981

merged 1 commit into from
Jun 20, 2017

Conversation

mistercrunch
Copy link
Member

  • upgrade celery to 4.0.2
  • using Redis for unit tests (sqla broker not supported in Celery 4)
  • Setting Celery's soft_time_limit based on SQLLAB_ASYNC_TIME_LIMIT_SEC config
  • Better error handling in async tasks
  • Better statsd logging in async tasks
  • show [pending/running] query status in Results tab
  • systematically using sqla NullPool on worker (async) to limit number
    of database connections

screen shot 2017-06-15 at 10 41 28 pm

@mistercrunch mistercrunch force-pushed the celery branch 4 times, most recently from a5e7d18 to 4be2dbe Compare June 20, 2017 05:31
@mistercrunch
Stabilizing Celery / SQL Lab
5f2796b 
* upgrade celery to 4.0.2
* using Redis for unit tests (sqla broker not supported in Celery 4)
* Setting Celery's soft_time_limit based on `SQLLAB_ASYNC_TIME_LIMIT_SEC` config
* Better error handling in async tasks
* Better statsd logging in async tasks
* show [pending/running] query status in Results tab
* systematically using sqla NullPool on worker (async) to limit number
  of database connections
@yolken
Copy link
Contributor

yolken commented Jun 20, 2017

LGTM

@mistercrunch mistercrunch merged commit 06fcaa3 into apache:master Jun 20, 2017
@mistercrunch mistercrunch deleted the celery branch June 20, 2017 20:55
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.18.5 labels Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ascott ascott Awaiting requested review from ascott

@yolken yolken Awaiting requested review from yolken

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.18.5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mistercrunch @yolken