Problem Exporting Charts as Image

[xiaoqufengdi]

It is wrong not to display a chart if it is not in the browser window display range. When we download the dashboard as a picture, we find that some charts are not displayed

#28713

fix(dashboard): load charts correctly

[github-actions]

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️

We hope to see you in our Slack community too! Not signed up? Use our Slack App to self-register.

[rusackas]

This PR disables a feature that was implemented to improve performance. We don't render all charts on a dashboard, but rather just render them when they're in the viewport. Dashboards with hundreds of charts will have poor performance with this change.

@kgabryje do you know of any way to make this change dynamic, so screenshots/alerts/reports/thumbnails/etc will work as expected? There are several GitHub issues about this, I'll try to find/link them here.

[xiaoqufengdi]

This PR disables a feature that was implemented to improve performance. We don't render all charts on a dashboard, but rather just render them when they're in the viewport. Dashboards with hundreds of charts will have poor performance with this change.

@kgabryje do you know of any way to make this change dynamic, so screenshots/alerts/reports/thumbnails/etc will work as expected? There are several GitHub issues about this, I'll try to find/link them here.

I understand the optimization, but you shouldn't hide it after the chart has been shown once.

[kgabryje]

@xiaoqufengdi Thanks for reporting! PR #29272 that was merged yesterday should fix the issue. Could you please verify that it works for you now?
CC @rusackas @geido

[geido]

I am closing this for now as the solution won't be merged as is. Please, feel free to verify that the new changes introduced in #29272 have fixed the issue or feel free to re-open the PR with an appropriate solution. Thanks for your help!