Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: updated Dutch translations #28710

Merged
merged 3 commits into from
May 29, 2024

Conversation

Seboeb
Copy link
Contributor

@Seboeb Seboeb commented May 27, 2024

SUMMARY

This PR updates the .po and .json file for the (missing) Dutch translations.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

image
image
image

TESTING INSTRUCTIONS

  • Activate nl (Dutch) language in superset_config.py
  • Navigate through dashboards and UI of Superset

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@github-actions github-actions bot added i18n Namespace | Anything related to localization i18n:dutch labels May 27, 2024
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️

We hope to see you in our Slack community too! Not signed up? Use our Slack App to self-register.

Copy link
Member

@mistercrunch mistercrunch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't speak dutch but this looks thoughtful and seems like great progress forward. It'd be great to have some sort of dashboard with per-language completion %

Copy link

codecov bot commented May 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.47%. Comparing base (76d897e) to head (91b2551).
Report is 235 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #28710       +/-   ##
===========================================
+ Coverage   60.48%   83.47%   +22.98%     
===========================================
  Files        1931      523     -1408     
  Lines       76236    37575    -38661     
  Branches     8568        0     -8568     
===========================================
- Hits        46114    31366    -14748     
+ Misses      28017     6209    -21808     
+ Partials     2105        0     -2105     
Flag Coverage Δ
hive 49.01% <ø> (-0.16%) ⬇️
javascript ?
mysql 77.09% <ø> (?)
postgres 77.23% <ø> (?)
presto 53.56% <ø> (-0.25%) ⬇️
python 83.47% <ø> (+19.98%) ⬆️
sqlite 76.68% <ø> (?)
unit 58.94% <ø> (+1.32%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mistercrunch
Copy link
Member

I just fixed the end-of-file error, for next PR please install the pre-commit hooks -> https://superset.apache.org/docs/contributing/development/#git-hooks

@Seboeb
Copy link
Contributor Author

Seboeb commented May 29, 2024

I just fixed the end-of-file error, for next PR please install the pre-commit hooks -> https://superset.apache.org/docs/contributing/development/#git-hooks

Thanks, and yes I will do so

@rusackas rusackas merged commit f066247 into apache:master May 29, 2024
34 checks passed
EnxDev pushed a commit to EnxDev/superset that referenced this pull request May 31, 2024
Co-authored-by: Maxime Beauchemin <maximebeauchemin@gmail.com>
@Seboeb Seboeb deleted the update-dutch-translations branch August 14, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i18n:dutch i18n Namespace | Anything related to localization size/XXL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants