[doc] Pip Cryptography Install Version #2549
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Description: Adding a specific version to the pip install intructions for cryptography. Why: So that it matches the required version in setup.py. Without this, the latest version is installed with the correct flags and then when setup.py is ran 1.7.2 is installed with no flags which will cause other errors. Changes: Added specific verion to pip install.
|
I wonder if we should just bump the version to the latest in setup.py ? |
|
@mistercrunch It is generally good to stay up to date with the latest with security packages so I would be in favor of bumping the version to the latest. I'm not sure the process that you use to test/validate a new package version though. Let me know if I can help. I thought this would be a less controversial change than bumping the version. |
|
I'll do a round of bumping now. This service makes it straightforward: |
|
I bumped the version to the latest. |
|
👍 Thanks @mistercrunch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Adding a specific version to the pip install intructions for
cryptography.
Why:
So that it matches the required version in setup.py.
Without this, the latest version is installed with the correct flags and
then when setup.py is ran 1.7.2 is installed with no flags which will
cause other errors.
Changes:
Added specific verion to pip install.