Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove deprecated apis copy_dash, save_dash and add_slices #24353

Merged
merged 16 commits into from
Jun 13, 2023

Conversation

dpgaspar
Copy link
Member

@dpgaspar dpgaspar commented Jun 12, 2023

SUMMARY

Removes deprecated APIs:

  • /superset/copy_dash/int:dashboard_id/
  • /superset/save_dash/int:dashboard_id/
  • /superset/add_slices/int:dashboard_id/

Effort on removing deprecated API from /superset: #24332

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jun 12, 2023

Codecov Report

Merging #24353 (1504d19) into master (c09b8c6) will increase coverage by 1.81%.
The diff coverage is n/a.

❗ Current head 1504d19 differs from pull request most recent head 7fa6c97. Consider uploading reports for the commit 7fa6c97 to get more accurate results

@@            Coverage Diff             @@
##           master   #24353      +/-   ##
==========================================
+ Coverage   67.18%   68.99%   +1.81%     
==========================================
  Files        1903     1903              
  Lines       74275    74196      -79     
  Branches     8110     8110              
==========================================
+ Hits        49898    51194    +1296     
+ Misses      22265    20890    -1375     
  Partials     2112     2112              
Flag Coverage Δ
hive 54.04% <ø> (?)
javascript 55.62% <ø> (ø)
mysql 79.30% <ø> (-0.04%) ⬇️
postgres 79.38% <ø> (-0.04%) ⬇️
presto 53.97% <ø> (?)
python 83.35% <ø> (+3.79%) ⬆️
sqlite 77.89% <ø> (-0.04%) ⬇️
unit 54.46% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/dashboard/actions/hydrate.js 2.04% <ø> (ø)
superset/views/core.py 74.75% <ø> (-0.78%) ⬇️

... and 99 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dpgaspar dpgaspar requested a review from geido June 12, 2023 10:19
Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dpgaspar dpgaspar merged commit ca478bd into apache:master Jun 13, 2023
@dpgaspar dpgaspar deleted the chore/remove-deprecated-apis-5 branch June 13, 2023 14:08
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants