docs(contributing): added note for creating SECRET_KEY #23417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
nytai
reviewed
Mar 20, 2023
| @@ -26,6 +26,8 @@ pip install -r requirements/testing.txt | |||
| pip install -e . | |||
|
|
|||
| # Initialize the database | |||
| # Note: For generating a SECRET_KEY if you haven't done already, you can use the command: | |||
| # echo "SECRET_KEY='$(openssl rand -base64 42)'" | tee -a superset_config.py | |||
There was a problem hiding this comment.
If running with FLASK_ENV = development this shouldn't be necessary for running, but still good to have this so users aren't confused when trying to run prod
There was a problem hiding this comment.
If running with
FLASK_ENV = developmentthis shouldn't be necessary for running, but still good to have this so users aren't confused when trying to run prod
@nytai Yeah. that was the idea in the change that @dpgaspar made in #23186, but it's not working, as per my issue #23288
Maybe you have an idea how to make #23186 work as intended.
nytai
approved these changes
Mar 20, 2023
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
In the steps of installing locally the flask backend, if the SECRET_KEY has not been already generated, I thought adding a step for generating the SECRET_KEY would be good, as I was searching for it.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
BEFORE
AFTER
Highlighted the newly added comment
TESTING INSTRUCTIONS
There are no steps necessary for testing as this is a documentation change.
ADDITIONAL INFORMATION