Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Dashboard containing a tab and a filter with "Select first filter value by default" enabled doesn't load #23268

Closed
wants to merge 1 commit into from

Conversation

lilykuang
Copy link
Member

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:
dashboard_tabs_before

After:
dashboard_tabs_after

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@sfirke
Copy link
Member

sfirke commented Mar 3, 2023

It seems this makes the affected dashboards load (yay!) by automatically expanding the Filters out of scope list. This is an improvement over the dashboards failing to load, but in my testing I now see the Filters out of scope list expanded by default on every tab as I click around my dashboards.

Is there a way that the failure-to-load bug could be fixed while retaining the very elegant behavior of automatically hiding irrelevant filters as users click between tabs?

@kgabryje
Copy link
Member

kgabryje commented Mar 3, 2023

Could we try to figure out an alternative solution? Like @sfirke said, the out of scope filters should be collapsed by default. 1 reason is the UX, but it also serves as an optimisation to reduce the number of requests sent when dashboard loads - the filters out of scope don't send their api requests until they change their state to "in scope" or the collapsed section is uncollapsed

@lilykuang
Copy link
Member Author

Thank you @kgabryje for upcoming with a better solution #23299 I will close this PR

@lilykuang lilykuang closed this Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants