Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Force configuration for SafeMarkdown component in Handlebars #22417

Merged
merged 2 commits into from
Dec 14, 2022

Conversation

geido
Copy link
Member

@geido geido commented Dec 14, 2022

SUMMARY

This PR modifies the Handlebars component so that the configurations for the SafeMarkdown component are applied.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N.A.

TESTING INSTRUCTIONS

The Handlebars component should work as expected and behave based on the HTML_SANITIZATION and HTML_SANITIZATION_SCHEMA_EXTENSIONS configuration properties.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Dec 14, 2022

Codecov Report

Merging #22417 (a63d5d4) into master (1014a32) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master   #22417      +/-   ##
==========================================
- Coverage   66.89%   66.88%   -0.01%     
==========================================
  Files        1847     1847              
  Lines       70611    70616       +5     
  Branches     7749     7752       +3     
==========================================
  Hits        47233    47233              
- Misses      21362    21367       +5     
  Partials     2016     2016              
Flag Coverage Δ
hive 52.49% <ø> (ø)
javascript 53.85% <0.00%> (-0.01%) ⬇️
mysql 77.97% <ø> (ø)
postgres 78.04% <ø> (ø)
presto 52.39% <ø> (ø)
python 81.24% <ø> (ø)
sqlite 76.50% <ø> (ø)
unit 50.88% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ars/src/components/Handlebars/HandlebarsViewer.tsx 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@geido geido changed the title chore: Force configuration for SafeMarkdown component chore: Force configuration for SafeMarkdown component in Dec 14, 2022
@geido geido changed the title chore: Force configuration for SafeMarkdown component in chore: Force configuration for SafeMarkdown component in Handlebars Dec 14, 2022
@michael-s-molina michael-s-molina changed the title chore: Force configuration for SafeMarkdown component in Handlebars fix: Force configuration for SafeMarkdown component in Handlebars Dec 14, 2022
Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michael-s-molina michael-s-molina merged commit ebaa949 into master Dec 14, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
@mistercrunch mistercrunch deleted the chore/handlebars-safemarkdown-config branch March 26, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S v2.0 v2.0.1 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants