Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Mistaken use of BootstrapUser type #21892

Merged
merged 1 commit into from
Oct 20, 2022

Conversation

codyml
Copy link
Member

@codyml codyml commented Oct 20, 2022

SUMMARY

In #21351, I changed a use of type User to type BootstrapUser because code relied on roles and permissions being present. However, I didn't realize that BootstrapUser is an optional type. This PR changes that use of BootstrapUser to UserWithRolesAndPermissions..

TESTING INSTRUCTIONS

  • Linting, typing, unit, integration and end-to-end tests should pass.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Oct 20, 2022

Codecov Report

Merging #21892 (361dc35) into master (9a063ab) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #21892   +/-   ##
=======================================
  Coverage   55.55%   55.55%           
=======================================
  Files        1806     1806           
  Lines       69140    69140           
  Branches     7393     7393           
=======================================
  Hits        38409    38409           
  Misses      28822    28822           
  Partials     1909     1909           
Flag Coverage Δ
javascript 53.31% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@michael-s-molina michael-s-molina merged commit e418694 into apache:master Oct 20, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants