Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add USER_CLIENT_ERRORS to stop logging exceptions that are user driven #21818

Merged
merged 1 commit into from
Oct 15, 2022

Conversation

hughhhh
Copy link
Member

@hughhhh hughhhh commented Oct 14, 2022

SUMMARY

Creating an easy way for us to define user prone sip-41 errors and logging them as warnings instead of exceptions.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@hughhhh hughhhh marked this pull request as ready for review October 14, 2022 17:13
@codecov
Copy link

codecov bot commented Oct 14, 2022

Codecov Report

Merging #21818 (f626856) into master (df3b5a8) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master   #21818      +/-   ##
==========================================
- Coverage   66.85%   66.83%   -0.02%     
==========================================
  Files        1805     1805              
  Lines       69061    69062       +1     
  Branches     7369     7369              
==========================================
- Hits        46169    46156      -13     
- Misses      20995    21009      +14     
  Partials     1897     1897              
Flag Coverage Δ
hive 52.92% <100.00%> (+<0.01%) ⬆️
mysql ?
postgres 78.30% <100.00%> (+<0.01%) ⬆️
presto 52.82% <100.00%> (+<0.01%) ⬆️
python 81.40% <100.00%> (-0.05%) ⬇️
sqlite 76.79% <100.00%> (+<0.01%) ⬆️
unit 51.06% <50.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/sqllab/command.py 84.00% <100.00%> (+0.12%) ⬆️
superset/common/utils/dataframe_utils.py 90.47% <0.00%> (-4.77%) ⬇️
superset/db_engine_specs/mysql.py 94.04% <0.00%> (-4.77%) ⬇️
superset/models/core.py 89.41% <0.00%> (-0.71%) ⬇️
superset/views/core.py 75.60% <0.00%> (-0.46%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@hughhhh hughhhh merged commit 6f2e76b into master Oct 15, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
@mistercrunch mistercrunch deleted the add-user-error branch March 26, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants