Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove deprecated ETagResponseMixin #21773

Merged
merged 1 commit into from
Oct 12, 2022

Conversation

eschutho
Copy link
Member

@eschutho eschutho commented Oct 11, 2022

SUMMARY

The Werkzeug 2.1 release removed some deprecated code and merged the ETagResponseMixin into the Response class. Instead of pinning superset to any flask or werkzeug version, I'm returning the Response object here instead of the mixin so that we can continue to support later versions. This seems to be an issue commonly found in Ubuntu systems.

ADDITIONAL INFORMATION

  • Has associated issue: Fixes ModuleNotFoundError: No module named 'werkzeug.wrappers.etag' #20723
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Oct 11, 2022

Codecov Report

Merging #21773 (bf20b3f) into master (bd3166b) will decrease coverage by 11.37%.
The diff coverage is 100.00%.

❗ Current head bf20b3f differs from pull request most recent head ef1f60d. Consider uploading reports for the commit ef1f60d to get more accurate results

@@             Coverage Diff             @@
##           master   #21773       +/-   ##
===========================================
- Coverage   66.88%   55.50%   -11.38%     
===========================================
  Files        1802     1802               
  Lines       68987    68987               
  Branches     7345     7345               
===========================================
- Hits        46139    38291     -7848     
- Misses      20951    28799     +7848     
  Partials     1897     1897               
Flag Coverage Δ
hive 52.93% <100.00%> (ø)
mysql ?
postgres ?
presto 52.83% <100.00%> (ø)
python 57.93% <100.00%> (-23.53%) ⬇️
sqlite ?
unit 51.05% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/utils/cache.py 54.46% <100.00%> (-20.54%) ⬇️
superset/utils/dashboard_import_export.py 0.00% <0.00%> (-100.00%) ⬇️
superset/tags/core.py 4.54% <0.00%> (-95.46%) ⬇️
superset/key_value/commands/update.py 0.00% <0.00%> (-90.91%) ⬇️
superset/key_value/commands/delete.py 0.00% <0.00%> (-87.88%) ⬇️
superset/key_value/commands/delete_expired.py 0.00% <0.00%> (-84.00%) ⬇️
superset/dashboards/commands/importers/v0.py 15.62% <0.00%> (-76.25%) ⬇️
superset/datasets/commands/update.py 25.00% <0.00%> (-69.05%) ⬇️
superset/datasets/commands/importers/v0.py 24.03% <0.00%> (-69.00%) ⬇️
superset/datasets/commands/create.py 31.25% <0.00%> (-68.75%) ⬇️
... and 284 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@zhaoyongjie zhaoyongjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixing, LGTM.

@eschutho eschutho merged commit 75e6a04 into apache:master Oct 12, 2022
eschutho added a commit to preset-io/superset that referenced this pull request Oct 18, 2022
@eschutho eschutho deleted the elizabeth/fix-werkzeug-typing branch October 21, 2022 20:59
Fahrenheit35 pushed a commit to Fahrenheit35/superset that referenced this pull request Nov 11, 2022
@mistercrunch mistercrunch added 🍒 2.0.1 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS v2.0 v2.0.1 🍒 2.0.1 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants