Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(database-list): hide upload file button if no permission #21216

Merged
merged 1 commit into from
Aug 30, 2022

Conversation

stephenLYZ
Copy link
Member

SUMMARY

We should hide the upload file button If no upload options are available.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

before

2022-08-27.12.47.36.mov

after

2022-08-27.12.46.33.mov

TESTING INSTRUCTIONS

  • Change a user to Alpha role
  • Go to the database
  • Make sure all database CSV upload is not allowed
  • Using. the Alpha role account, see the result

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@github-actions
Copy link
Contributor

Storybook has completed and can be viewed at

@codecov
Copy link

codecov bot commented Aug 26, 2022

Codecov Report

Merging #21216 (9488d28) into master (394d62e) will increase coverage by 0.06%.
The diff coverage is 40.00%.

@@            Coverage Diff             @@
##           master   #21216      +/-   ##
==========================================
+ Coverage   66.27%   66.34%   +0.06%     
==========================================
  Files        1770     1781      +11     
  Lines       67524    67882     +358     
  Branches     7178     7256      +78     
==========================================
+ Hits        44754    45033     +279     
- Misses      20936    20985      +49     
- Partials     1834     1864      +30     
Flag Coverage Δ
javascript 52.26% <40.00%> (+0.26%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...tend/src/views/CRUD/data/database/DatabaseList.tsx 66.00% <40.00%> (-2.37%) ⬇️
...n-chart-handlebars/src/plugin/controls/orderBy.tsx 28.57% <0.00%> (-11.43%) ⬇️
...ase/DatabaseModal/DatabaseConnectionForm/index.tsx 90.90% <0.00%> (-9.10%) ⬇️
...s/plugin-chart-echarts/src/Gauge/transformProps.ts 76.92% <0.00%> (-4.90%) ⬇️
...eModal/DatabaseConnectionForm/CommonParameters.tsx 85.71% <0.00%> (-4.29%) ⬇️
...ashboard/components/BuilderComponentPane/index.tsx 76.47% <0.00%> (-2.48%) ⬇️
...tend/plugins/plugin-chart-table/src/TableChart.tsx 40.46% <0.00%> (-1.46%) ⬇️
...gin-chart-echarts/src/Timeseries/transformProps.ts 53.57% <0.00%> (-1.08%) ⬇️
...frontend/src/SqlLab/components/SqlEditor/index.jsx 50.58% <0.00%> (-1.05%) ⬇️
...d/src/SqlLab/components/TabbedSqlEditors/index.jsx 55.17% <0.00%> (-0.95%) ⬇️
... and 89 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@geido geido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@stephenLYZ stephenLYZ merged commit 0c43190 into apache:master Aug 30, 2022
eschutho pushed a commit that referenced this pull request Sep 20, 2022
Fahrenheit35 pushed a commit to Fahrenheit35/superset that referenced this pull request Nov 11, 2022
@mistercrunch mistercrunch added 🍒 1.5.3 🍒 2.0.1 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M v1.5 v2.0 v2.0.1 🍒 1.5.3 🍒 2.0.1 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants