Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add embedded docs configuration details to extensions registry #21052

Merged

Conversation

jfrag1
Copy link
Member

@jfrag1 jfrag1 commented Aug 11, 2022

SUMMARY

At Preset, we require more than just the embedded dashboard id to configure our SDK. This extension will allow us to display all the information required to embed a dashboard in one spot, improving the experience of embedding a dashboard.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Aug 11, 2022

Codecov Report

Merging #21052 (c93a45a) into master (4f1996d) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master   #21052      +/-   ##
==========================================
- Coverage   66.27%   66.26%   -0.01%     
==========================================
  Files        1769     1769              
  Lines       67475    67477       +2     
  Branches     7171     7172       +1     
==========================================
  Hits        44716    44716              
- Misses      20928    20930       +2     
  Partials     1831     1831              
Flag Coverage Δ
javascript 52.00% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...set-ui-core/src/ui-overrides/ExtensionsRegistry.ts 100.00% <ø> (ø)
...rc/dashboard/components/DashboardEmbedControls.tsx 9.09% <0.00%> (-0.35%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jfrag1
Copy link
Member Author

jfrag1 commented Aug 12, 2022

@lilykuang Can you press the merge button on this please?

@lilykuang lilykuang merged commit 394d62e into apache:master Aug 12, 2022
@lilykuang lilykuang deleted the jack/add-embedded-config-details-extension branch August 12, 2022 23:33
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants