fix: Respecting max/min opacities, and adding tests. #20555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #20555 +/- ##
==========================================
- Coverage 66.75% 66.58% -0.17%
==========================================
Files 1739 1752 +13
Lines 65138 67087 +1949
Branches 6898 7448 +550
==========================================
+ Hits 43480 44667 +1187
- Misses 19908 20576 +668
- Partials 1750 1844 +94
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
rusackas
changed the title
| @@ -50,6 +50,8 @@ describe('getOpacity', () => { | |||
| expect(getOpacity(100, 100, 50)).toEqual(0.05); | |||
| expect(getOpacity(100, 100, 100, 0, 0.8)).toEqual(0.8); | |||
| expect(getOpacity(100, 100, 50, 0, 1)).toEqual(0); | |||
| expect(getOpacity(999, 100, 50, 0, 1)).toEqual(1); | |||
| expect(getOpacity(-999, 100, 50, 0, 1)).toEqual(0.05); | |||
There was a problem hiding this comment.
Math.abs inside the function will make sure result is never negative. We can replace this test with one that passes a high minOpacity like 0.9 and parameters that make result be less than this value to test result < minOpacity
Suggested change
| expect(getOpacity(-999, 100, 50, 0, 1)).toEqual(0.05); |
sadpandajoe
pushed a commit
to preset-io/superset
that referenced
this pull request
Jun 30, 2022
* Respecting max/min opacities, and adding tests. * revising tests * Adding missing test case for maximum coverage :) * removing unnecessary logic and test * adding another unit test for (hopefully) full coverage. * no more ternary operator * New approach with Math.min - take THAT codecov. * one more stab at making codecov happy... ignoring the file next. * lint fixes (cherry picked from commit ac8e502)
|
🏷️ preset:2022.25 |
michael-s-molina
pushed a commit
that referenced
this pull request
Jul 6, 2022
* Respecting max/min opacities, and adding tests. * revising tests * Adding missing test case for maximum coverage :) * removing unnecessary logic and test * adding another unit test for (hopefully) full coverage. * no more ternary operator * New approach with Math.min - take THAT codecov. * one more stab at making codecov happy... ignoring the file next. * lint fixes (cherry picked from commit ac8e502)
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
There was an error where calculated opacities could be over 1, or below 0. This code will only allow the opacity to go to the configured maximum or minimum.
Hat tip to @michael-s-molina for the detective work here :)
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
Unit tests included!
ADDITIONAL INFORMATION