Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Adding extra metrics issue after chart configuration #20410

Merged

Conversation

codemaster08240328
Copy link
Contributor

SUMMARY

If we set the alignment on some columns, then start adding new metrics, the metrics throw an error and things break.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

BEFORE:

image (2)

AFTER:
[DEV] Explore - birth_names - 16 June 2022 - Watch Video

TESTING INSTRUCTIONS

  1. Create a Table Chart aggregating data.
  2. Add some Columns and Metrics.
  3. Execute your Chart.
  4. Save it.
  5. Try to add/remove Metrics from it.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Contributor

@diegomedina248 diegomedina248 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM code wise, let's spin an env to test

Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix! If it's possible to add a regression test for this (perhaps using Cypress), that would be a nice follow-up

@codecov
Copy link

codecov bot commented Jun 16, 2022

Codecov Report

Merging #20410 (65a3e03) into master (467d8ef) will not change coverage.
The diff coverage is n/a.

❗ Current head 65a3e03 differs from pull request most recent head b68e94f. Consider uploading reports for the commit b68e94f to get more accurate results

@@           Coverage Diff           @@
##           master   #20410   +/-   ##
=======================================
  Coverage   66.70%   66.70%           
=======================================
  Files        1739     1739           
  Lines       65135    65135           
  Branches     6897     6897           
=======================================
  Hits        43450    43450           
  Misses      19932    19932           
  Partials     1753     1753           
Flag Coverage Δ
javascript 51.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...et-frontend/src/explore/reducers/exploreReducer.js 34.78% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 467d8ef...b68e94f. Read the comment docs.

@rusackas rusackas merged commit a8a6b73 into apache:master Jun 16, 2022
@rusackas
Copy link
Member

LGTM code wise, let's spin an env to test

I successfully tested the branch locally. Lookin' good!

sadpandajoe pushed a commit to preset-io/superset that referenced this pull request Jun 16, 2022
@sadpandajoe
Copy link
Member

🏷️ preset:2022.23

michael-s-molina pushed a commit that referenced this pull request Jun 23, 2022
@mistercrunch mistercrunch added 🍒 2.0.0 🍒 2.0.1 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset:2022.23 Preset-Patch size/XS v2.0 🍒 2.0.0 🍒 2.0.1 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants