Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: setting limit value when Pie chart switches #20392

Merged
merged 1 commit into from
Jun 15, 2022

Conversation

zhaoyongjie
Copy link
Member

@zhaoyongjie zhaoyongjie commented Jun 15, 2022

SUMMARY

Currently, when we use a Pie chart on a high cardinality column as a dimension, the Pie chart will be crashed.

Now we have a new mechanism to set a new control value for each control when the chart is switched.

In this PR, if the chart switch to the Pie and row_limit is greater than 100, the row_limit will be set to default value 100.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

After

pie.limit.mov

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@zhaoyongjie zhaoyongjie marked this pull request as ready for review June 15, 2022 11:32
@codecov
Copy link

codecov bot commented Jun 15, 2022

Codecov Report

Merging #20392 (ec99a8a) into master (df8bb46) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master   #20392      +/-   ##
==========================================
- Coverage   66.69%   66.69%   -0.01%     
==========================================
  Files        1739     1739              
  Lines       65153    65154       +1     
  Branches     6903     6904       +1     
==========================================
  Hits        43453    43453              
- Misses      19947    19948       +1     
  Partials     1753     1753              
Flag Coverage Δ
javascript 51.72% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...gins/plugin-chart-echarts/src/Pie/controlPanel.tsx 28.57% <0.00%> (-4.77%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df8bb46...ec99a8a. Read the comment docs.

Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@stephenLYZ stephenLYZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@zhaoyongjie zhaoyongjie merged commit 0a50a9b into apache:master Jun 15, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants