Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: derived metrics use different line style #20242

Merged
merged 4 commits into from
Jun 5, 2022

Conversation

zhaoyongjie
Copy link
Member

SUMMARY

The legacy line chart(NVD3) with the time shift has a feature that the derived metrics were displayed dashed line rather than a solid line. For example, a Line Chart has a metric be called sum(sales), and select time shift 1 month ago in Advanced Analytics, the line of sum(sales) was displayed solid line and derived metric sum(sales)__1 month ago was displayed dashed line.

This PR introduces this feature on the new chart.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

After

image

Before

image

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@stephenLYZ
Copy link
Member

/testenv up

@github-actions
Copy link
Contributor

github-actions bot commented Jun 2, 2022

@stephenLYZ Container image not yet published for this PR. Please try again when build is complete.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 2, 2022

@stephenLYZ Ephemeral environment creation failed. Please check the Actions logs for details.

@codecov
Copy link

codecov bot commented Jun 2, 2022

Codecov Report

Merging #20242 (f92bf75) into master (d4f320f) will increase coverage by 0.00%.
The diff coverage is 87.50%.

@@           Coverage Diff           @@
##           master   #20242   +/-   ##
=======================================
  Coverage   66.48%   66.48%           
=======================================
  Files        1726     1727    +1     
  Lines       64790    64798    +8     
  Branches     6829     6832    +3     
=======================================
+ Hits        43076    43083    +7     
  Misses      19978    19978           
- Partials     1736     1737    +1     
Flag Coverage Δ
javascript 51.34% <87.50%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...gin-chart-echarts/src/Timeseries/transformProps.ts 58.33% <0.00%> (-0.62%) ⬇️
...lugin-chart-echarts/src/Timeseries/transformers.ts 50.40% <ø> (ø)
...rt-controls/src/operators/utils/isDerivedSeries.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4f320f...f92bf75. Read the comment docs.

@rusackas
Copy link
Member

rusackas commented Jun 3, 2022

/testenv up

@github-actions
Copy link
Contributor

github-actions bot commented Jun 3, 2022

@rusackas Ephemeral environment spinning up at http://35.88.137.13:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

Copy link
Member

@stephenLYZ stephenLYZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@zhaoyongjie zhaoyongjie merged commit 7faf874 into apache:master Jun 5, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jun 5, 2022

Ephemeral environment shutdown and build artifacts deleted.

@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants