Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: change button name in Sql Lab #20163

Merged
merged 1 commit into from
May 23, 2022

Conversation

AAfghahi
Copy link
Member

SUMMARY

Changes the name of Explore to Create Chart to be more explicit.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:

Screen Shot 2022-05-23 at 2 02 18 PM

After:
Screen Shot 2022-05-23 at 2 04 40 PM

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented May 23, 2022

Codecov Report

Merging #20163 (9ec30d7) into master (d5c5e58) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #20163   +/-   ##
=======================================
  Coverage   66.45%   66.45%           
=======================================
  Files        1721     1721           
  Lines       64497    64509   +12     
  Branches     6805     6811    +6     
=======================================
+ Hits        42860    42870   +10     
- Misses      19905    19906    +1     
- Partials     1732     1733    +1     
Flag Coverage Δ
javascript 51.34% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...c/SqlLab/components/ExploreResultsButton/index.tsx 100.00% <ø> (ø)
...end/src/dashboard/components/SliceHeader/index.tsx 86.27% <0.00%> (-0.96%) ⬇️
superset-frontend/src/explore/fixtures.tsx 66.66% <0.00%> (ø)
...perset-frontend/src/utils/getControlsForVizType.js 92.85% <0.00%> (ø)
...set-frontend/src/explore/actions/exploreActions.ts 50.00% <0.00%> (ø)
...et-frontend/src/components/EditableTitle/index.tsx 70.00% <0.00%> (ø)
...et-frontend/src/explore/reducers/exploreReducer.js 28.75% <0.00%> (ø)
...ntend/src/explore/controlUtils/getControlConfig.ts 100.00% <0.00%> (ø)
...nd/src/explore/components/DataTablesPane/index.tsx 71.55% <0.00%> (ø)
...plugins/legacy-plugin-chart-heatmap/src/Heatmap.js 0.00% <0.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5c5e58...9ec30d7. Read the comment docs.

@AAfghahi AAfghahi merged commit b96e20a into apache:master May 23, 2022
philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/XS 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants