fix(cosmetic): Limiting modal height

[rusackas]

SUMMARY

Sets flexbox layout details on modals so that they don't get too tall for the viewport and cut off action buttons. Now they go to a reasonable max hight, and scroll within the max bounds.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:

After:

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[codecov]

Codecov Report

Merging #20147 (0e1d78c) into master (e2f11d3) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master   #20147      +/-   ##
==========================================
- Coverage   66.45%   66.42%   -0.03%     
==========================================
  Files        1721     1722       +1     
  Lines       64497    64772     +275     
  Branches     6805     6897      +92     
==========================================
+ Hits        42860    43027     +167     
- Misses      19905    20000      +95     
- Partials     1732     1745      +13     

Flag	Coverage Δ
hive	53.70% <ø> (ø)
javascript	51.40% <100.00%> (+0.06%)	⬆️
mysql	82.14% <ø> (ø)
postgres	82.20% <ø> (ø)
presto	53.56% <ø> (ø)
python	82.62% <ø> (ø)
sqlite	81.94% <ø> (ø)
unit	49.40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
superset-frontend/src/components/Modal/Modal.tsx	86.76% <100.00%> (+0.61%)	⬆️
...end/src/dashboard/components/SliceHeader/index.tsx	84.37% <0.00%> (-2.86%)	⬇️
.../src/explore/components/DataTableControl/index.tsx	69.81% <0.00%> (-0.86%)	⬇️
...et-frontend/src/explore/reducers/exploreReducer.js	28.26% <0.00%> (-0.49%)	⬇️
...ntend/src/explore/controlUtils/getControlConfig.ts	100.00% <0.00%> (ø)
...plugins/legacy-plugin-chart-heatmap/src/Heatmap.js	0.00% <0.00%> (ø)
...es/superset-ui-core/src/query/buildQueryContext.ts	100.00% <0.00%> (ø)
...lore/components/useOriginalFormattedTimeColumns.ts	75.00% <0.00%> (ø)
...set-frontend/src/explore/actions/exploreActions.ts	52.00% <0.00%> (+2.00%)	⬆️
...et-frontend/src/components/EditableTitle/index.tsx	73.91% <0.00%> (+3.91%)	⬆️
... and 3 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2f11d3...0e1d78c. Read the comment docs.

[kgabryje]

Lgtm!