Handle filters with integer values #2004
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xrmx
reviewed
Jan 19, 2017
| @@ -260,9 +260,15 @@ def query_filters(self, is_having_filter=False): | |||
| if not (col and vals): | |||
| continue | |||
| elif col in self.datasource.filterable_column_names: | |||
| # Quote values with comma to avoid conflict | |||
| vals = ["'{}'".format(x) if "," in x else x for x in vals] | |||
There was a problem hiding this comment.
This should work fine too:
vals = ["'{}'".format(x) if "," in x else "{}".format(x) for x in vals]
There was a problem hiding this comment.
No, it won't because it will still try to test if "," is in x which fails when x is an integer.
There was a problem hiding this comment.
ah! got it. What about this?
from six import text_type
vals = map(text_type, vals)
vals = [u"'{}'".format(x) if "," in x else x for x in vals]
|
should be fixed on master already: #1978 |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing #1640
query_filterswas surrounding filter value with quotes if the value contains,. Leading that if the value was an integer it fails onif "," in x.Casting value to string fixes both UI problems listed in the issue.
PS: I tried to not cast the value from integer to string, but then DB request wasn't working. So this fix seems to be more appropriate.
PS: This part doesn't seem to be tested, am I wrong?