Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugin-chart-echarts): tooltip of big number truncated at then bottom #20029

Merged
merged 1 commit into from
May 13, 2022

Conversation

stephenLYZ
Copy link
Member

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

before

image

after

image

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented May 11, 2022

Codecov Report

Merging #20029 (c045916) into master (99f1f9e) will decrease coverage by 0.20%.
The diff coverage is 75.57%.

❗ Current head c045916 differs from pull request most recent head ac766a2. Consider uploading reports for the commit ac766a2 to get more accurate results

@@            Coverage Diff             @@
##           master   #20029      +/-   ##
==========================================
- Coverage   66.53%   66.33%   -0.21%     
==========================================
  Files        1714     1713       -1     
  Lines       65043    64083     -960     
  Branches     6723     6734      +11     
==========================================
- Hits        43278    42509     -769     
+ Misses      20054    19863     -191     
  Partials     1711     1711              
Flag Coverage Δ
javascript 51.27% <60.89%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...perset-ui-core/src/chart/components/SuperChart.tsx 100.00% <ø> (ø)
...ugins/legacy-plugin-chart-calendar/src/Calendar.js 0.00% <ø> (ø)
...legacy-plugin-chart-calendar/src/ReactCalendar.jsx 0.00% <0.00%> (ø)
...egacy-plugin-chart-world-map/src/ReactWorldMap.jsx 0.00% <0.00%> (ø)
...gins/legacy-plugin-chart-world-map/src/WorldMap.js 0.00% <ø> (ø)
...acy-preset-chart-deckgl/src/components/Tooltip.tsx 0.00% <0.00%> (ø)
...BigNumber/BigNumberWithTrendline/transformProps.ts 46.96% <ø> (ø)
...s/plugin-chart-pivot-table/src/PivotTableChart.tsx 0.00% <0.00%> (ø)
...ns/plugin-chart-word-cloud/src/chart/WordCloud.tsx 0.00% <0.00%> (ø)
...preset-chart-xy/src/components/BoxPlot/BoxPlot.tsx 0.00% <0.00%> (ø)
... and 88 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99f1f9e...ac766a2. Read the comment docs.

Copy link
Member

@zhaoyongjie zhaoyongjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the fix.

@stephenLYZ stephenLYZ merged commit 35e6e27 into apache:master May 13, 2022
philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants