-
Notifications
You must be signed in to change notification settings - Fork 13.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: URI form is blank when trying to connect from sql lab #20004
fix: URI form is blank when trying to connect from sql lab #20004
Conversation
Codecov Report
@@ Coverage Diff @@
## master #20004 +/- ##
=======================================
Coverage 66.28% 66.28%
=======================================
Files 1712 1712
Lines 63968 63969 +1
Branches 6731 6731
=======================================
+ Hits 42404 42405 +1
Misses 19853 19853
Partials 1711 1711
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for the fix.
🏷️ preset:2022.19 |
) (cherry picked from commit cc026e9)
SUMMARY
The connect a database modal, when in the SQL Lab, is not displaying the information in the URI form.
The reason is that the SQL Lab uses and customizes the antd Tabs component, and by changing the design it also affects this modal.
This PR sets the proper styles for the modal, to set and prevent this issue
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
Screen.Recording.2022-05-09.at.16.55.42.mov
After:
new.mov
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION