feat: switch from sqlalchemy-trino to trino-python-client
#19957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #19957 +/- ##
==========================================
- Coverage 66.27% 66.11% -0.17%
==========================================
Files 1712 1712
Lines 63957 63957
Branches 6720 6720
==========================================
- Hits 42390 42284 -106
- Misses 19859 19965 +106
Partials 1708 1708
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
betodealmeida
approved these changes
May 5, 2022
| @@ -64,7 +64,7 @@ def get_git_sha() -> str: | |||
| zip_safe=False, | |||
| entry_points={ | |||
| "console_scripts": ["superset=superset.cli.main:superset"], | |||
| "sqlalchemy.dialects": ["trinonative = sqlalchemy_trino.dialect:TrinoDialect"], | |||
| "sqlalchemy.dialects": ["trinonative = trino.sqlalchemy.dialect:TrinoDialect"], | |||
There was a problem hiding this comment.
Hopefully we'll get a new PyHive release soon and we'll get rid of this.
hughhhh
pushed a commit
to hve-labs/superset
that referenced
this pull request
May 11, 2022
philipher29
pushed a commit
to ValtechMobility/superset
that referenced
this pull request
Jun 9, 2022
2 tasks
This was referenced Nov 16, 2022
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Hello there,
I'm the author of
sqlalchemy-trino, which is Trino (f.k.a PrestoSQL) dialect for SQLAlchemy.Since trinodb/trino-python-client#81, all its code of is merged into upstream project. And
sqlalchemy-trinois deprecated.So SuperSet should switch from
sqlalchemy-trinototrino-python-clientThis PR also update
trino.mdxdocs from #17593, which may being lost during refactoring.ADDITIONAL INFORMATION