-
Notifications
You must be signed in to change notification settings - Fork 13.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Adds the theme object to chart properties #19951
chore: Adds the theme object to chart properties #19951
Conversation
Codecov Report
@@ Coverage Diff @@
## master #19951 +/- ##
==========================================
- Coverage 66.53% 66.52% -0.01%
==========================================
Files 1714 1714
Lines 65044 65084 +40
Branches 6723 6725 +2
==========================================
+ Hits 43278 43300 +22
- Misses 20055 20072 +17
- Partials 1711 1712 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, exciting stuff!
SUMMARY
This PR adds the theme object to chart properties and adjusts the tests accordingly. This is a prerequisite for applying themes to plugins.
TESTING INSTRUCTIONS
1 - Execute all tests
2 - All tests must pass
ADDITIONAL INFORMATION