Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: deprecate /superset/validate_sql_json migrate to api v1 #19935

Conversation

dpgaspar
Copy link
Member

@dpgaspar dpgaspar commented May 3, 2022

SUMMARY

Following plan to gradually deprecate "REST" endpoints on /superset namespace.

Deprecates /superset/validate_sql_json. Proposed removal on Superset 3.0

New endpoint /api/v1/database/<int:database_id>/validate_sql

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@dpgaspar dpgaspar marked this pull request as ready for review May 4, 2022 11:28
@codecov
Copy link

codecov bot commented May 4, 2022

Codecov Report

Merging #19935 (8f51998) into master (62e1c34) will decrease coverage by 0.00%.
The diff coverage is 52.74%.

❗ Current head 8f51998 differs from pull request most recent head 787ae3a. Consider uploading reports for the commit 787ae3a to get more accurate results

@@            Coverage Diff             @@
##           master   #19935      +/-   ##
==========================================
- Coverage   54.36%   54.36%   -0.01%     
==========================================
  Files        1712     1713       +1     
  Lines       63968    64058      +90     
  Branches     6731     6731              
==========================================
+ Hits        34778    34826      +48     
- Misses      27479    27521      +42     
  Partials     1711     1711              
Flag Coverage Δ
hive 53.65% <53.33%> (-0.01%) ⬇️
presto 53.51% <53.33%> (-0.01%) ⬇️
python 57.69% <53.33%> (-0.02%) ⬇️
unit 48.64% <53.33%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/SqlLab/actions/sqlLab.js 60.39% <0.00%> (ø)
superset/constants.py 100.00% <ø> (ø)
superset/views/core.py 35.14% <0.00%> (-0.03%) ⬇️
superset/databases/commands/validate_sql.py 36.00% <36.00%> (ø)
superset/databases/api.py 49.51% <40.00%> (-0.49%) ⬇️
superset/databases/commands/exceptions.py 93.84% <100.00%> (+1.84%) ⬆️
superset/databases/schemas.py 73.40% <100.00%> (+0.87%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62e1c34...787ae3a. Read the comment docs.

@dpgaspar dpgaspar requested a review from villebro May 10, 2022 07:35
Copy link
Member

@betodealmeida betodealmeida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Go v1 API! :)

@dpgaspar dpgaspar merged commit 87a4379 into apache:master May 10, 2022
@dpgaspar dpgaspar deleted the danielgaspar/sc-42037/migrate-superset-validate-sql-json-to-api branch May 10, 2022 20:25
hughhhh pushed a commit to hve-labs/superset that referenced this pull request May 11, 2022
…#19935)

* feat: deprecate /superset/validate_sql_json migrate to api v1

* use new error handling

* migrate SQLLAb frontend and add tests

* debug test

* debug test

* fix frontend test on sqllab

* fix tests

* fix frontend test on sqllab

* fix tests

* fix tests

* fix tests

* fix tests
philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
…#19935)

* feat: deprecate /superset/validate_sql_json migrate to api v1

* use new error handling

* migrate SQLLAb frontend and add tests

* debug test

* debug test

* fix frontend test on sqllab

* fix tests

* fix frontend test on sqllab

* fix tests

* fix tests

* fix tests

* fix tests
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/L 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants