Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: change subject name from no_name to named for PNGs in #19929

Merged
merged 1 commit into from
May 5, 2022

Conversation

AAfghahi
Copy link
Member

@AAfghahi AAfghahi commented May 2, 2022

SUMMARY

Previously images in reports or alerts looked like this:

image

this PR changes them to have this:
[chart or dashboard name] [date of screenshot].png

After:

Screen Shot 2022-05-04 at 5 03 50 PM

Screen Shot 2022-05-04 at 5 04 52 PM

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented May 2, 2022

Codecov Report

Merging #19929 (2a44304) into master (1fa841e) will decrease coverage by 0.15%.
The diff coverage is 100.00%.

❗ Current head 2a44304 differs from pull request most recent head a8c2f16. Consider uploading reports for the commit a8c2f16 to get more accurate results

@@            Coverage Diff             @@
##           master   #19929      +/-   ##
==========================================
- Coverage   66.51%   66.35%   -0.16%     
==========================================
  Files        1715     1715              
  Lines       65060    65063       +3     
  Branches     6723     6723              
==========================================
- Hits        43272    43170     -102     
- Misses      20076    20181     +105     
  Partials     1712     1712              
Flag Coverage Δ
hive ?
mysql ?
postgres 81.99% <100.00%> (?)
presto ?
python 82.03% <100.00%> (-0.33%) ⬇️
sqlite 81.75% <100.00%> (+<0.01%) ⬆️
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/datasets/dao.py 93.79% <100.00%> (ø)
superset/utils/core.py 89.74% <100.00%> (-0.09%) ⬇️
superset/db_engines/hive.py 0.00% <0.00%> (-85.19%) ⬇️
superset/db_engine_specs/hive.py 70.11% <0.00%> (-15.71%) ⬇️
superset/common/utils/dataframe_utils.py 85.71% <0.00%> (-7.15%) ⬇️
superset/db_engine_specs/presto.py 83.36% <0.00%> (-5.34%) ⬇️
superset/db_engine_specs/mysql.py 93.97% <0.00%> (-3.62%) ⬇️
superset/connectors/sqla/models.py 88.84% <0.00%> (-1.20%) ⬇️
superset/models/core.py 88.38% <0.00%> (-0.95%) ⬇️
superset/views/core.py 76.61% <0.00%> (-0.45%) ⬇️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1fa841e...a8c2f16. Read the comment docs.

@AAfghahi AAfghahi force-pushed the ch40654_subjectName branch 2 times, most recently from f1d856c to 518d6c6 Compare May 2, 2022 20:21
@AAfghahi
Copy link
Member Author

AAfghahi commented May 2, 2022

/testenv up FEATURE_ALERT_REPORTS=True

@github-actions
Copy link
Contributor

github-actions bot commented May 2, 2022

@AAfghahi Ephemeral environment spinning up at http://54.214.133.2:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@AAfghahi AAfghahi added the need:qa-review Requires QA review label May 4, 2022
image.add_header("Content-ID", "<%s>" % msgid)
image.add_header("Content-Disposition", "inline")
image.add_header("Content-Disposition", 'attachment; filename="%s"' % file_name)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's the difference between this line, and what we're doing in line 937?

Copy link
Member Author

@AAfghahi AAfghahi May 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good question, I am running it now without the file in image to see. The documentation used both so I emulated and then wasn't able to properly test until just recently.

Copy link
Member Author

@AAfghahi AAfghahi May 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I tested, and the add_header line seems inconsequential to the process that we want, so I deleted it.

@jinghua-qa
Copy link
Member

screenshot looks good to me!

@AAfghahi AAfghahi merged commit 2e2053f into apache:master May 5, 2022
@github-actions
Copy link
Contributor

github-actions bot commented May 5, 2022

Ephemeral environment shutdown and build artifacts deleted.

hughhhh pushed a commit to hve-labs/superset that referenced this pull request May 11, 2022
philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels need:qa-review Requires QA review size/XS 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants