fix(dataset): DAO update

[betodealmeida]

SUMMARY

The dataset DAO.update method was not committing even when asked to. This PR fixes it.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A

TESTING INSTRUCTIONS

N/A

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[codecov]

Codecov Report

Merging #19926 (f7440a1) into master (1fa841e) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master   #19926      +/-   ##
==========================================
- Coverage   66.51%   66.47%   -0.04%     
==========================================
  Files        1715     1715              
  Lines       65060    65060              
  Branches     6723     6723              
==========================================
- Hits        43272    43249      -23     
- Misses      20076    20099      +23     
  Partials     1712     1712              

Flag	Coverage Δ
hive	52.90% <0.00%> (ø)
mysql	81.94% <100.00%> (ø)
presto	52.75% <0.00%> (ø)
python	82.28% <100.00%> (-0.08%)	⬇️
sqlite	?
unit	48.03% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
superset/datasets/dao.py	93.79% <100.00%> (ø)
superset/sqllab/sql_json_executer.py	64.63% <0.00%> (-9.76%)	⬇️
superset/sqllab/execution_context_convertor.py	78.26% <0.00%> (-8.70%)	⬇️
superset/db_engine_specs/sqlite.py	91.89% <0.00%> (-5.41%)	⬇️
superset/utils/celery.py	86.20% <0.00%> (-3.45%)	⬇️
superset/connectors/sqla/utils.py	88.75% <0.00%> (-2.50%)	⬇️
superset/result_set.py	96.77% <0.00%> (-1.62%)	⬇️
superset/databases/commands/test_connection.py	98.57% <0.00%> (-1.43%)	⬇️
superset/models/slice.py	84.95% <0.00%> (-0.49%)	⬇️
superset/db_engine_specs/base.py	88.01% <0.00%> (-0.34%)	⬇️
... and 1 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1fa841e...f7440a1. Read the comment docs.

[sadpandajoe]

🏷️ preset:2022.17