Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Adds a storybook to FilterableTable #19897

Conversation

michael-s-molina
Copy link
Member

SUMMARY

  • Adds a storybook to FilterableTable
  • Uses an index in the component folder to facilitate imports
  • Replaces hard-coded colors with colors from the theme

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screen Shot 2022-04-29 at 11 23 31 AM

TESTING INSTRUCTIONS

Check the FilterableTable storybook.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Apr 29, 2022

Codecov Report

Merging #19897 (e1f53f2) into master (e1f53f2) will not change coverage.
The diff coverage is n/a.

❗ Current head e1f53f2 differs from pull request most recent head db61796. Consider uploading reports for the commit db61796 to get more accurate results

@@           Coverage Diff           @@
##           master   #19897   +/-   ##
=======================================
  Coverage   66.53%   66.53%           
=======================================
  Files        1714     1714           
  Lines       65044    65044           
  Branches     6723     6723           
=======================================
  Hits        43278    43278           
  Misses      20055    20055           
  Partials     1711     1711           
Flag Coverage Δ
hive 52.90% <0.00%> (ø)
javascript 51.26% <0.00%> (ø)
mysql 81.95% <0.00%> (ø)
postgres 81.99% <0.00%> (ø)
presto 52.76% <0.00%> (ø)
python 82.41% <0.00%> (ø)
sqlite 81.75% <0.00%> (ø)
unit 48.03% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1f53f2...db61796. Read the comment docs.

@michael-s-molina michael-s-molina merged commit 7657e42 into apache:master May 3, 2022
hughhhh pushed a commit to hve-labs/superset that referenced this pull request May 11, 2022
philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants