-
Notifications
You must be signed in to change notification settings - Fork 13.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Regression on Data and Alerts & Reports Headers #19850
fix: Regression on Data and Alerts & Reports Headers #19850
Conversation
Codecov Report
@@ Coverage Diff @@
## master #19850 +/- ##
==========================================
- Coverage 66.55% 66.47% -0.08%
==========================================
Files 1692 1713 +21
Lines 64802 64943 +141
Branches 6657 6690 +33
==========================================
+ Hits 43129 43172 +43
- Misses 19973 20067 +94
- Partials 1700 1704 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
(cherry picked from commit 7645eac)
🏷️ preset:2022.17 |
SUMMARY
Fixes a regression that happened when trying to fix a "li inside li" error. Switching the tag removed some of the styles applied to the submenu.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
Screen.Recording.2022-04-26.at.08.48.31.mov
After:
Screen.Recording.2022-04-26.at.08.23.31.mov
TESTING INSTRUCTIONS
Visit the Data subsection (Databases/Datasets/Saved queries/Saved history) and ensure the tabs display as showcased in the after video.
ADDITIONAL INFORMATION