Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Clean redundant dependency from useMemo dep array #19732

Merged
merged 1 commit into from
Apr 15, 2022

Conversation

kgabryje
Copy link
Member

SUMMARY

Follow up of #19651 (comment)

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Apr 15, 2022

Codecov Report

Merging #19732 (b0ab4b9) into master (c320c29) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head b0ab4b9 differs from pull request most recent head d92866a. Consider uploading reports for the commit d92866a to get more accurate results

@@            Coverage Diff             @@
##           master   #19732      +/-   ##
==========================================
- Coverage   66.51%   66.51%   -0.01%     
==========================================
  Files        1686     1686              
  Lines       64589    64588       -1     
  Branches     6636     6636              
==========================================
- Hits        42959    42958       -1     
  Misses      19931    19931              
  Partials     1699     1699              
Flag Coverage Δ
javascript 51.17% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ontrols/DndColumnSelectControl/DndColumnSelect.tsx 35.00% <100.00%> (-1.07%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c320c29...d92866a. Read the comment docs.

@kgabryje kgabryje merged commit b7759e6 into apache:master Apr 15, 2022
villebro pushed a commit that referenced this pull request Apr 25, 2022
philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
@mistercrunch mistercrunch added 🍒 1.5.0 🍒 1.5.1 🍒 1.5.2 🍒 1.5.3 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels lts-v1 size/XS 🍒 1.5.0 🍒 1.5.1 🍒 1.5.2 🍒 1.5.3 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants