Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(embedded): API get embedded dashboard config by uuid #19650

Merged
merged 5 commits into from
Apr 12, 2022

Conversation

lilykuang
Copy link
Member

SUMMARY

  • GET embedded config by uuid API endpoint with tests
  • validate the creation of guest token with dashboard id or embedded config uuid

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Apr 11, 2022

Codecov Report

Merging #19650 (5ac9f57) into master (9554135) will decrease coverage by 0.06%.
The diff coverage is 95.77%.

@@            Coverage Diff             @@
##           master   #19650      +/-   ##
==========================================
- Coverage   66.47%   66.41%   -0.07%     
==========================================
  Files        1681     1683       +2     
  Lines       64467    64500      +33     
  Branches     6607     6593      -14     
==========================================
- Hits        42856    42836      -20     
- Misses      19917    19980      +63     
+ Partials     1694     1684      -10     
Flag Coverage Δ
hive ?
mysql 81.95% <95.77%> (+0.04%) ⬆️
postgres 81.99% <95.77%> (+0.04%) ⬆️
presto 52.54% <64.78%> (+0.02%) ⬆️
python 82.21% <95.77%> (-0.18%) ⬇️
sqlite 81.77% <95.77%> (+0.04%) ⬆️
unit 47.75% <64.78%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/embedded/api.py 93.33% <93.33%> (ø)
superset/embedded_dashboard/commands/exceptions.py 100.00% <100.00%> (ø)
superset/initialization/__init__.py 91.72% <100.00%> (+0.05%) ⬆️
superset/security/api.py 96.72% <100.00%> (+0.23%) ⬆️
superset/security/manager.py 95.26% <100.00%> (+0.51%) ⬆️
superset/db_engines/hive.py 0.00% <0.00%> (-85.19%) ⬇️
superset/db_engine_specs/hive.py 70.11% <0.00%> (-15.71%) ⬇️
...tend/src/views/CRUD/data/database/DatabaseList.tsx 67.94% <0.00%> (-1.29%) ⬇️
superset/db_engine_specs/base.py 88.01% <0.00%> (-0.34%) ⬇️
superset/connectors/sqla/models.py 89.27% <0.00%> (-0.19%) ⬇️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9554135...5ac9f57. Read the comment docs.

Copy link
Member

@suddjian suddjian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good!

@lilykuang lilykuang merged commit 224769b into apache:master Apr 12, 2022
@suddjian suddjian mentioned this pull request Apr 20, 2022
9 tasks
philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
* feat(embedded): get embedded dashboard config by uuid

* add tests and validation

* remove accidentally commit

* fix tests
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/L 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants