Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(explore): Change copy of cross filters checkbox #19646

Merged
merged 1 commit into from
Apr 13, 2022

Conversation

kgabryje
Copy link
Member

@kgabryje kgabryje commented Apr 11, 2022

SUMMARY

Change the cross filters checkbox copy from Emit dashboard cross filters to Enable dashboard cross filters

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:
image

After:
image

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Member

@zhaoyongjie zhaoyongjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Apr 11, 2022

Codecov Report

Merging #19646 (0f75b6b) into master (a6bf041) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #19646      +/-   ##
==========================================
- Coverage   66.45%   66.44%   -0.02%     
==========================================
  Files        1681     1681              
  Lines       64389    64408      +19     
  Branches     6592     6593       +1     
==========================================
+ Hits        42792    42797       +5     
- Misses      19914    19927      +13     
- Partials     1683     1684       +1     
Flag Coverage Δ
javascript 51.13% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...controls/src/shared-controls/emitFilterControl.tsx 50.00% <ø> (ø)
...rontend/src/components/ListView/Filters/Search.tsx 70.58% <0.00%> (-7.99%) ⬇️
...rset-frontend/src/components/ListView/ListView.tsx 94.11% <0.00%> (-4.64%) ⬇️
...erset-frontend/src/components/EmptyState/index.tsx 71.42% <0.00%> (-2.94%) ⬇️
...frontend/src/components/ListView/Filters/index.tsx 66.66% <0.00%> (-2.57%) ⬇️
...perset-frontend/src/views/CRUD/alert/AlertList.tsx 66.66% <0.00%> (-1.05%) ⬇️
...rontend/src/components/ListView/Filters/Select.tsx 55.00% <0.00%> (-0.56%) ⬇️
...ntend/src/views/CRUD/annotation/AnnotationList.tsx 69.35% <0.00%> (-0.49%) ⬇️
...ews/CRUD/annotationlayers/AnnotationLayersList.tsx 68.05% <0.00%> (-0.44%) ⬇️
superset-frontend/src/components/Button/index.tsx 100.00% <0.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6bf041...0f75b6b. Read the comment docs.

@kgabryje kgabryje merged commit 4a5dddf into apache:master Apr 13, 2022
philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants