Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sqloxide optional #19570

Merged
merged 1 commit into from
Apr 6, 2022
Merged

Conversation

betodealmeida
Copy link
Member

SUMMARY

A user complained that #19416 broke Superset in aarch64, probably because of the new sqlioxide dependency. This PR makes it optional, and recommends people to install it to improve performance in the migration.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A

TESTING INSTRUCTIONS

N/A

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@betodealmeida betodealmeida requested a review from a team as a code owner April 6, 2022 16:18
@betodealmeida betodealmeida force-pushed the sqloxide_optional branch 3 times, most recently from ff5ea09 to e1e5904 Compare April 6, 2022 17:16
@codecov
Copy link

codecov bot commented Apr 6, 2022

Codecov Report

Merging #19570 (7fd31a6) into master (444b4f5) will decrease coverage by 0.19%.
The diff coverage is 42.85%.

❗ Current head 7fd31a6 differs from pull request most recent head 9b376e6. Consider uploading reports for the commit 9b376e6 to get more accurate results

@@            Coverage Diff             @@
##           master   #19570      +/-   ##
==========================================
- Coverage   66.65%   66.46%   -0.20%     
==========================================
  Files        1680     1680              
  Lines       64271    64277       +6     
  Branches     6564     6564              
==========================================
- Hits        42842    42720     -122     
- Misses      19727    19855     +128     
  Partials     1702     1702              
Flag Coverage Δ
hive ?
mysql 81.89% <42.85%> (-0.01%) ⬇️
postgres 81.94% <42.85%> (-0.01%) ⬇️
presto ?
python 81.98% <42.85%> (-0.41%) ⬇️
sqlite ?
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/migrations/shared/utils.py 75.55% <42.85%> (-6.50%) ⬇️
superset/db_engines/hive.py 0.00% <0.00%> (-85.19%) ⬇️
superset/db_engine_specs/hive.py 70.11% <0.00%> (-15.71%) ⬇️
superset/connectors/sqla/utils.py 89.13% <0.00%> (-5.44%) ⬇️
superset/db_engine_specs/sqlite.py 91.89% <0.00%> (-5.41%) ⬇️
superset/db_engine_specs/presto.py 83.64% <0.00%> (-5.39%) ⬇️
superset/utils/celery.py 86.20% <0.00%> (-3.45%) ⬇️
superset/result_set.py 96.77% <0.00%> (-1.62%) ⬇️
superset/databases/commands/test_connection.py 98.57% <0.00%> (-1.43%) ⬇️
superset/connectors/sqla/models.py 88.10% <0.00%> (-1.21%) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 444b4f5...9b376e6. Read the comment docs.

@betodealmeida betodealmeida merged commit 6136942 into apache:master Apr 6, 2022
philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
michael-s-molina pushed a commit that referenced this pull request Aug 30, 2022
@mistercrunch mistercrunch added 🍒 1.5.2 🍒 1.5.3 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🍒 1.5.2 🍒 1.5.3 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants