fix: View Results Doesn't Match Chart After Refreshing Cache #19540
Conversation
diegomedina248
force-pushed
the
fix/view-results-does-not-match-chart-after-refreshing-cache
branch
from
25d4280
to
edf9773
Compare
Codecov Report
@@ Coverage Diff @@
## master #19540 +/- ##
=======================================
Coverage 66.55% 66.55%
=======================================
Files 1692 1692
Lines 64801 64806 +5
Branches 6657 6657
=======================================
+ Hits 43128 43132 +4
- Misses 19973 19974 +1
Partials 1700 1700
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
| return getChartDataRequest({ | ||
| formData: queryFormData, | ||
| resultFormat: 'json', | ||
| force: !!latestQueryCacheInvalidatedRef.current, | ||
| resultType, | ||
| ownState, | ||
| }) |
There was a problem hiding this comment.
I remember that the force field is in the explore state, but I can not get a True value even though I clicked the cached button. Could we resolve this issue through change the force value?
There was a problem hiding this comment.
As far as I can tell, that force is used for something else, which is tracked in the ExploreViewContainer.
I also cannot find where in the exploreReducer that is being modified, but updating that value there will have other consequences
There was a problem hiding this comment.
@diegomedina248 I pushed a branch in my repository to fix this issue. discussion welcome.
There was a problem hiding this comment.
@zhaoyongjie looks good to me! feel free to close this PR once yours lands here. Thanks
There was a problem hiding this comment.
@zhaoyongjie were you indeed opening a PR to resolve this, or just providing some advice/examples?
There was a problem hiding this comment.
@rusackas @diegomedina248 I will open a new PR today. Thanks.
diegomedina248
force-pushed
the
fix/view-results-does-not-match-chart-after-refreshing-cache
branch
from
edf9773
to
083ec4b
Compare
|
Closing in favor of #19932 |
SUMMARY
When the data cache is configured, after a cache invalidation in the explore, the results view is not impacted.
So, if we modify the underlying dataset while using the explore, and we try to invalidate the cache, then the chart correctly displays the new data, but the view results doesn't.
This PR ensures that, after a cache invalidation, both the chart and results reflect the latest data.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
Screen.Recording.2022-04-05.at.20.33.35.mov
After:
new.mov
TESTING INSTRUCTIONS
Ensure that, after cache invalidation, both the chart and data results view reflect the latest data.
ADDITIONAL INFORMATION