Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove FilterBox.less #19462

Merged
merged 4 commits into from
Apr 7, 2022
Merged

chore: Remove FilterBox.less #19462

merged 4 commits into from
Apr 7, 2022

Conversation

geido
Copy link
Member

@geido geido commented Mar 31, 2022

SUMMARY

Removes the FilterBox.less file from the FilterBox component.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

No visual changes

TESTING INSTRUCTIONS

  1. Create a FilterBox chart
  2. Add filters
  3. Make sure no visual changes can be observed
  4. Add the FilterBox to a Dashboard
  5. Open and set all the filters
  6. Make sure no visual changes can be observed

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@@ -409,37 +439,56 @@ class FilterBox extends React.PureComponent {
return filtersFields.map(filterConfig => {
const { label, key } = filterConfig;
return (
<div key={key} className="m-b-5 filter-container">
<StyledFilterContainer key={key} className="filter-container">
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This className is used by other less files. We should probably remove it once all the less files have been removed from the codebase

@codecov
Copy link

codecov bot commented Apr 1, 2022

Codecov Report

Merging #19462 (6190d5d) into master (6b136c2) will increase coverage by 0.10%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master   #19462      +/-   ##
==========================================
+ Coverage   66.57%   66.68%   +0.10%     
==========================================
  Files        1675     1678       +3     
  Lines       64092    64231     +139     
  Branches     6519     6561      +42     
==========================================
+ Hits        42672    42833     +161     
+ Misses      19729    19705      -24     
- Partials     1691     1693       +2     
Flag Coverage Δ
javascript 51.52% <100.00%> (+0.27%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rontend/src/visualizations/FilterBox/FilterBox.jsx 48.85% <100.00%> (+1.19%) ⬆️
.../components/ExploreAdditionalActionsMenu/index.jsx 57.14% <0.00%> (-38.32%) ⬇️
...set-frontend/src/components/ReportModal/styles.tsx 87.50% <0.00%> (-12.50%) ⬇️
...rc/explore/components/ExploreChartHeader/index.jsx 42.10% <0.00%> (-6.58%) ⬇️
...rset-frontend/src/components/ReportModal/index.tsx 78.46% <0.00%> (-3.63%) ⬇️
...set-frontend/src/views/CRUD/alert/ExecutionLog.tsx 80.95% <0.00%> (-3.26%) ⬇️
.../explore/components/ExploreViewContainer/index.jsx 54.39% <0.00%> (-2.60%) ⬇️
...d/components/DashboardBuilder/DashboardBuilder.tsx 70.88% <0.00%> (-1.85%) ⬇️
...d/src/SqlLab/components/AceEditorWrapper/index.tsx 43.85% <0.00%> (-0.97%) ⬇️
superset-frontend/src/views/CRUD/hooks.ts 46.36% <0.00%> (-0.80%) ⬇️
... and 70 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b136c2...6190d5d. Read the comment docs.

Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@geido geido merged commit 6d5771a into apache:master Apr 7, 2022
@geido geido added the global:theming Related to theming Superset label Apr 7, 2022
philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
* Remove FilterBox less

* Fix test

* Add theme top level

* Use styledMount
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels global:theming Related to theming Superset size/L 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants