Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Remove legacy sql alchemy db connection link from G Sheet connection #19450

Conversation

codemaster08240328
Copy link
Contributor

SUMMARY

When we add google sheet as a database, we still have legacy SQLAlchemy url connection method, which is not supported anymore.

So removed this from the GSheet connection.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:
image

After:
image

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Mar 30, 2022

Codecov Report

Merging #19450 (b6035fd) into master (9a9e3b6) will increase coverage by 0.00%.
The diff coverage is 66.66%.

@@           Coverage Diff           @@
##           master   #19450   +/-   ##
=======================================
  Coverage   66.49%   66.49%           
=======================================
  Files        1681     1681           
  Lines       64370    64372    +2     
  Branches     6583     6584    +1     
=======================================
+ Hits        42803    42805    +2     
  Misses      19886    19886           
  Partials     1681     1681           
Flag Coverage Δ
javascript 51.17% <66.66%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...c/views/CRUD/data/database/DatabaseModal/index.tsx 32.17% <66.66%> (+0.36%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a9e3b6...b6035fd. Read the comment docs.

)}
viewBox="0 -6 24 24"
/>
{dbModel.name !== 'Google Sheets' && (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we check the engine against gsheets instead?
It's done like that in the same file, so if we can, we should use the same checking method.
And probably move that gsheets engine string to a constant.

@rusackas rusackas merged commit 9407598 into apache:master Apr 14, 2022
philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
…ction (apache#19450)

* feat: Remove legacy sql alchemy db connection link from G Sheet connection

* resolve comment
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels Preset-Patch size/M 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants