chore: Remove Control.less in Explore #19415
Conversation
Codecov Report
@@ Coverage Diff @@
## master #19415 +/- ##
=======================================
Coverage 66.48% 66.48%
=======================================
Files 1670 1670
Lines 63968 63970 +2
Branches 6512 6512
=======================================
+ Hits 42531 42533 +2
Misses 19748 19748
Partials 1689 1689
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
| @@ -76,7 +78,7 @@ export default function Control(props: ControlProps) { | |||
| } | |||
|
|
|||
| return ( | |||
| <div | |||
| <StyledControl | |||
| className="Control" | |||
There was a problem hiding this comment.
| className="Control" |
There was a problem hiding this comment.
@michael-s-molina this class is used by some Cypress tests, reason why I haven't removed it
There was a problem hiding this comment.
Can we change the Cypress tests to query by role or an id? Leaving the class name misleads the developers when maintaining the style because they need to look for the class definition to avoid conflicts.
There was a problem hiding this comment.
@michael-s-molina for this I need to correct myself. I found out that also superset-frontend/src/explore/components/DatasourcePanel/index.tsx is using it, so we should probably keep it there
mistercrunch
added
🏷️ bot
SUMMARY
It removes the Control.less file from the Control component in Explore.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
No visual changes
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION