Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: native filter dropdown not attached to parent node #19399

Merged

Conversation

diegomedina248
Copy link
Contributor

SUMMARY

This PR addresses the issue mentioned in #18102
By attaching the select popover to the parent node, we ensure it's tied to the left side content and thus scroll with it.
We can also leverage the Select's own calculations for top/bottom placement.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:

Screen.Recording.2022-03-28.at.14.35.47.mov

After:

Screen.Recording.2022-03-28.at.14.27.25.mov

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Mar 28, 2022

Codecov Report

Merging #19399 (fc19945) into master (1b4d8dd) will decrease coverage by 0.16%.
The diff coverage is 33.33%.

❗ Current head fc19945 differs from pull request most recent head e614d80. Consider uploading reports for the commit e614d80 to get more accurate results

@@            Coverage Diff             @@
##           master   #19399      +/-   ##
==========================================
- Coverage   66.59%   66.43%   -0.17%     
==========================================
  Files        1682     1670      -12     
  Lines       64314    63960     -354     
  Branches     6559     6507      -52     
==========================================
- Hits        42832    42491     -341     
- Misses      19781    19783       +2     
+ Partials     1701     1686      -15     
Flag Coverage Δ
javascript 51.32% <33.33%> (-0.05%) ⬇️
presto ?
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...c/filters/components/Select/SelectFilterPlugin.tsx 64.10% <33.33%> (-0.38%) ⬇️
superset/migrations/shared/utils.py 0.00% <0.00%> (-82.06%) ⬇️
superset/connectors/sqla/views.py 63.67% <0.00%> (-27.38%) ⬇️
...uperset-frontend/src/explore/exploreUtils/index.js 63.90% <0.00%> (-17.12%) ⬇️
superset-frontend/src/utils/urlUtils.ts 36.73% <0.00%> (-10.21%) ⬇️
...perset-frontend/src/explore/components/Control.tsx 53.84% <0.00%> (-6.16%) ⬇️
...erset-frontend/src/components/EmptyState/index.tsx 69.23% <0.00%> (-5.13%) ⬇️
superset-frontend/src/components/Icons/Icon.tsx 95.23% <0.00%> (-4.77%) ⬇️
superset/db_engine_specs/presto.py 84.30% <0.00%> (-4.72%) ⬇️
...nd/src/dashboard/components/gridComponents/Tab.jsx 80.48% <0.00%> (-3.19%) ⬇️
... and 197 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b4d8dd...e614d80. Read the comment docs.

@rusackas
Copy link
Member

rusackas commented Apr 5, 2022

/testenv up

@github-actions
Copy link
Contributor

github-actions bot commented Apr 5, 2022

@rusackas Ephemeral environment spinning up at http://54.184.17.120:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Works great in testing!

@diegomedina248 diegomedina248 force-pushed the fix/native-filter-dropdown-on-scroll branch from defccb6 to e614d80 Compare April 6, 2022 00:03
@rusackas rusackas merged commit c5b0dc3 into apache:master Apr 6, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Apr 6, 2022

Ephemeral environment shutdown and build artifacts deleted.

sadpandajoe pushed a commit to preset-io/superset that referenced this pull request Apr 6, 2022
@sadpandajoe
Copy link
Member

🏷️ preset:2022.13

philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 and removed 🚢 2.0.1 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset:2022.13 Preset-Patch size/XS 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants