Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: typo #19346

Merged
merged 1 commit into from
Mar 24, 2022
Merged

fix: typo #19346

merged 1 commit into from
Mar 24, 2022

Conversation

etr2460
Copy link
Member

@etr2460 etr2460 commented Mar 24, 2022

SUMMARY

found this while debugging an issue and it bothered me

TESTING INSTRUCTIONS

CI

to: @graceguo-supercat @ktmud

Copy link
Member

@ktmud ktmud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OCD for the win!

@codecov
Copy link

codecov bot commented Mar 24, 2022

Codecov Report

Merging #19346 (f3acf98) into master (9766726) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #19346   +/-   ##
=======================================
  Coverage   66.65%   66.65%           
=======================================
  Files        1674     1674           
  Lines       64631    64631           
  Branches     6503     6503           
=======================================
  Hits        43077    43077           
  Misses      19868    19868           
  Partials     1686     1686           
Flag Coverage Δ
hive 52.69% <ø> (ø)
javascript 51.31% <ø> (ø)
mysql 81.66% <ø> (ø)
postgres 81.71% <ø> (ø)
presto 52.54% <ø> (ø)
python 82.12% <ø> (ø)
sqlite 81.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...s/superset-ui-core/src/query/api/v1/handleError.ts 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9766726...f3acf98. Read the comment docs.

@dpgaspar dpgaspar merged commit 2af2d00 into master Mar 24, 2022
villebro pushed a commit that referenced this pull request Apr 3, 2022
(cherry picked from commit 2af2d00)
philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
@mistercrunch mistercrunch added 🍒 1.5.0 🍒 1.5.1 🍒 1.5.2 🍒 1.5.3 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
@mistercrunch mistercrunch deleted the etr2460-patch-5 branch March 26, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels lts-v1 size/XS 🍒 1.5.0 🍒 1.5.1 🍒 1.5.2 🍒 1.5.3 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants