Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(database): make to allow the expose db as default in sqlalchemy form db #19337

Merged
merged 1 commit into from
Mar 25, 2022

Conversation

prosdev0107
Copy link
Contributor

@prosdev0107 prosdev0107 commented Mar 23, 2022

SUMMARY

SQL lab advanced will show expose database in sql lab even though it was not selected in the URI database connection form

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

BEFORE:

By default, The option of Allow this database to be explored is not checked when the db is created with sqlalchemy form.
image

AFTER:
By default, he option of Allow this database to be explored is checked when the db is created with sqlalchemy form.
image

TESTING INSTRUCTIONS

How to reproduce the issue?

  1. Go through the onboard flow
  2. On the db connection screen, select something that uses the sql alchemy uri connection form like Athena or Elastic Search
  3. Go to the advanced tab (before the database is connected)
  4. Notice in the sql tab that expose database in sql lab is not checked
  5. connect to the database
  6. log into your workspace
  7. go to databases
  8. edit your connection
  9. Go to the advanced tab
  10. The expose database in sql lab is not checked by default

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@rusackas
Copy link
Member

Closing/reopening to kick CI in the pants.

@codecov
Copy link

codecov bot commented Mar 25, 2022

Codecov Report

Merging #19337 (675e4ea) into master (a08f83b) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #19337   +/-   ##
=======================================
  Coverage   66.64%   66.64%           
=======================================
  Files        1674     1674           
  Lines       64614    64627   +13     
  Branches     6502     6506    +4     
=======================================
+ Hits        43061    43071   +10     
- Misses      19868    19870    +2     
- Partials     1685     1686    +1     
Flag Coverage Δ
javascript 51.32% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...c/views/CRUD/data/database/DatabaseModal/index.tsx 32.90% <ø> (ø)
...rset-frontend/src/components/ReportModal/index.tsx 82.08% <0.00%> (-3.63%) ⬇️
...-ui-chart-controls/src/components/ColumnOption.tsx 84.61% <0.00%> (-1.10%) ⬇️
...l/AdhocFilterEditPopoverSimpleTabContent/index.tsx 65.07% <0.00%> (-0.53%) ⬇️
...et-ui-chart-controls/src/shared-controls/index.tsx 36.19% <0.00%> (-0.35%) ⬇️
...-ui-chart-controls/src/components/MetricOption.tsx 94.44% <0.00%> (-0.30%) ⬇️
superset-frontend/src/components/Select/Select.tsx 86.91% <0.00%> (ø)
...set-frontend/src/components/ReportModal/styles.tsx 100.00% <0.00%> (ø)
...frontend/src/SqlLab/components/ResultSet/index.tsx 50.49% <0.00%> (ø)
...erset-ui-chart-controls/src/components/Tooltip.tsx 80.00% <0.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a08f83b...675e4ea. Read the comment docs.

@rusackas rusackas merged commit 5ae7e54 into apache:master Mar 25, 2022
villebro pushed a commit that referenced this pull request Apr 3, 2022
philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
@mistercrunch mistercrunch added 🍒 1.5.0 🍒 1.5.1 🍒 1.5.2 🍒 1.5.3 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels lts-v1 Preset-Patch size/XS 🍒 1.5.0 🍒 1.5.1 🍒 1.5.2 🍒 1.5.3 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants