Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: SECRET_KEY Rotation Documentation #19233

Merged
merged 3 commits into from
Mar 23, 2022
Merged

docs: SECRET_KEY Rotation Documentation #19233

merged 3 commits into from
Mar 23, 2022

Conversation

sujiplr
Copy link
Contributor

@sujiplr sujiplr commented Mar 17, 2022

Additional documentation for SECRET_KEY rotation and SECRET_KEY setting up.

SUMMARY

Currently the SECRET_KEY rotation and SECRET_KEY setting up is missing in the documentation. So added the steps for covering the same.

Additional documentation for SECRET_KEY rotation and SECRET_KEY setting up.
Copy link
Member

@dpgaspar dpgaspar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple of comments, thank you for your contribution!

docs/docs/installation/configuring-superset.mdx Outdated Show resolved Hide resolved
# Your App secret key, this will be used for encrypting the data.
# Make sure you are changing this key for your deployment with a strong key.
# You can generate a strong key using `openssl rand -base64 42`

SECRET_KEY = '\2\1thisismyscretkey\1\2\e\y\y\h'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's remove this default on the docs

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

docs/docs/installation/running-on-kubernetes.mdx Outdated Show resolved Hide resolved
Bumped the helm chart version for the new changes.
Removed the default secret key value from the configuration docs.
@sujiplr sujiplr requested a review from dpgaspar March 17, 2022 12:10
@dpgaspar dpgaspar changed the title [WIP](docs):SECRET_KEY Rotation Documentation (docs):SECRET_KEY Rotation Documentation Mar 21, 2022
@dpgaspar
Copy link
Member

LGTM is it ready to go @sujiplr ?

@villebro villebro changed the title (docs):SECRET_KEY Rotation Documentation docs: SECRET_KEY Rotation Documentation Mar 21, 2022
@sujiplr
Copy link
Contributor Author

sujiplr commented Mar 21, 2022

LGTM is it ready to go @sujiplr ?

Yes.

@sujiplr sujiplr requested a review from dpgaspar March 22, 2022 11:35
Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, I'm sure this will be very helpful to lots of people!

@dpgaspar dpgaspar merged commit 54c521b into apache:master Mar 23, 2022
michael-hoffman-26 pushed a commit to nielsen-oss/superset that referenced this pull request Mar 23, 2022
* SECRET_KEY Rotation

Additional documentation for SECRET_KEY rotation and SECRET_KEY setting up.

* Bumped the helm chart version to 0.5.11

Bumped the helm chart version for the new changes.

* Removed the default secret key value from the configuration docs.

Removed the default secret key value from the configuration docs.
villebro pushed a commit that referenced this pull request Apr 3, 2022
* SECRET_KEY Rotation

Additional documentation for SECRET_KEY rotation and SECRET_KEY setting up.

* Bumped the helm chart version to 0.5.11

Bumped the helm chart version for the new changes.

* Removed the default secret key value from the configuration docs.

Removed the default secret key value from the configuration docs.
philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
* SECRET_KEY Rotation

Additional documentation for SECRET_KEY rotation and SECRET_KEY setting up.

* Bumped the helm chart version to 0.5.11

Bumped the helm chart version for the new changes.

* Removed the default secret key value from the configuration docs.

Removed the default secret key value from the configuration docs.
@mistercrunch mistercrunch added 🍒 1.5.0 🍒 1.5.1 🍒 1.5.2 🍒 1.5.3 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels lts-v1 size/M 🍒 1.5.0 🍒 1.5.1 🍒 1.5.2 🍒 1.5.3 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants