Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: SQL Lab autocomplete for selected tables #19047

Merged
merged 1 commit into from
Mar 10, 2022
Merged

Conversation

hughhhh
Copy link
Member

@hughhhh hughhhh commented Mar 7, 2022

SUMMARY

Updated logic to fix the autocomplete render in sqllab for selected tables in the left panel

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screen.Recording.2022-03-04.at.1.16.48.PM.mov

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@hughhhh hughhhh changed the title fix: SQL Lab autocomplete fix: SQL Lab autocomplete for selected tables Mar 7, 2022
@codecov
Copy link

codecov bot commented Mar 7, 2022

Codecov Report

Merging #19047 (32f43e1) into master (8c52fe3) will decrease coverage by 0.12%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #19047      +/-   ##
==========================================
- Coverage   66.52%   66.40%   -0.13%     
==========================================
  Files        1641     1645       +4     
  Lines       63476    63784     +308     
  Branches     6444     6537      +93     
==========================================
+ Hits        42227    42355     +128     
- Misses      19585    19748     +163     
- Partials     1664     1681      +17     
Flag Coverage Δ
hive 52.59% <ø> (ø)
javascript 51.55% <33.33%> (+0.26%) ⬆️
mysql ?
postgres ?
presto 52.43% <ø> (ø)
python 81.91% <ø> (-0.38%) ⬇️
sqlite 81.55% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...d/src/SqlLab/components/AceEditorWrapper/index.tsx 52.72% <33.33%> (+8.86%) ⬆️
superset/databases/commands/create.py 31.37% <0.00%> (-56.87%) ⬇️
superset/sql_validators/postgres.py 50.00% <0.00%> (-50.00%) ⬇️
superset/views/database/mixins.py 60.34% <0.00%> (-20.69%) ⬇️
superset/databases/commands/update.py 85.71% <0.00%> (-8.17%) ⬇️
superset/common/utils/dataframe_utils.py 85.71% <0.00%> (-7.15%) ⬇️
superset/databases/api.py 87.98% <0.00%> (-6.01%) ⬇️
superset/databases/dao.py 94.44% <0.00%> (-5.56%) ⬇️
superset/views/database/validators.py 78.94% <0.00%> (-5.27%) ⬇️
superset/databases/schemas.py 94.27% <0.00%> (-4.20%) ⬇️
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c52fe3...32f43e1. Read the comment docs.

@pkdotson
Copy link
Member

pkdotson commented Mar 7, 2022

/testenv up

@github-actions
Copy link
Contributor

github-actions bot commented Mar 7, 2022

@pkdotson Ephemeral environment spinning up at http://34.217.100.234:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@jinghua-qa jinghua-qa added the need:qa-review Requires QA review label Mar 9, 2022
@hughhhh
Copy link
Member Author

hughhhh commented Mar 9, 2022

/testenv up

@github-actions
Copy link
Contributor

github-actions bot commented Mar 9, 2022

@hughhhh Ephemeral environment spinning up at http://54.202.235.184:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

Copy link
Member

@jinghua-qa jinghua-qa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA tested passed. Verified autocomplete worked for table name when user have selected table in left panel

@hughhhh hughhhh merged commit a21d8a0 into master Mar 10, 2022
@github-actions
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

villebro pushed a commit that referenced this pull request Apr 3, 2022
(cherry picked from commit a21d8a0)
@mistercrunch mistercrunch added 🍒 1.5.0 🍒 1.5.1 🍒 1.5.2 🍒 1.5.3 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
@mistercrunch mistercrunch deleted the hugh/sql-autocomplete branch March 26, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels lts-v1 need:qa-review Requires QA review size/S 🍒 1.5.0 🍒 1.5.1 🍒 1.5.2 🍒 1.5.3 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants