Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add/find owners from report/alert modal #18971

Merged

Conversation

graceguo-supercat
Copy link

@graceguo-supercat graceguo-supercat commented Feb 28, 2022

SUMMARY

This PR is to fix an issue similar to #18725. Front-end should call API /related/created_by

TESTING INSTRUCTIONS

  1. create new Alert or Report
  2. add an owner. in dev environment the users list is very short so it won't show any issue. but in airbnb production, the list is very long, user can't find their own name from the list.

@codecov
Copy link

codecov bot commented Feb 28, 2022

Codecov Report

Merging #18971 (9d89911) into master (eafe0cf) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #18971   +/-   ##
=======================================
  Coverage   66.39%   66.39%           
=======================================
  Files        1641     1641           
  Lines       63515    63515           
  Branches     6422     6422           
=======================================
  Hits        42172    42172           
  Misses      19682    19682           
  Partials     1661     1661           
Flag Coverage Δ
javascript 51.01% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...frontend/src/views/CRUD/alert/AlertReportModal.tsx 52.23% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eafe0cf...9d89911. Read the comment docs.

@graceguo-supercat graceguo-supercat merged commit 7e336d1 into apache:master Feb 28, 2022
villebro pushed a commit that referenced this pull request Apr 3, 2022
@mistercrunch mistercrunch added 🍒 1.5.0 🍒 1.5.1 🍒 1.5.2 🍒 1.5.3 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels lts-v1 size/XS 🍒 1.5.0 🍒 1.5.1 🍒 1.5.2 🍒 1.5.3 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants