Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow uploads in crud view #18953

Merged
merged 20 commits into from
Mar 21, 2022
Merged

Conversation

pkdotson
Copy link
Member

@pkdotson pkdotson commented Feb 25, 2022

SUMMARY

This pr creates an additional dropdown in the subnav for the upload in the database crud view.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screen.Recording.2022-03-10.at.9.13.38.AM.mov

TESTING INSTRUCTIONS

Go to database crud view page and test upload a file dropdown.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@pull-request-size pull-request-size bot added size/L and removed size/M labels Mar 1, 2022
@codecov
Copy link

codecov bot commented Mar 1, 2022

Codecov Report

Merging #18953 (5f01fda) into master (8d53db1) will decrease coverage by 0.02%.
The diff coverage is 82.60%.

@@            Coverage Diff             @@
##           master   #18953      +/-   ##
==========================================
- Coverage   66.54%   66.52%   -0.03%     
==========================================
  Files        1646     1643       -3     
  Lines       63630    63589      -41     
  Branches     6475     6494      +19     
==========================================
- Hits        42343    42301      -42     
  Misses      19607    19607              
- Partials     1680     1681       +1     
Flag Coverage Δ
javascript 51.33% <82.60%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/views/components/Menu.tsx 58.97% <ø> (ø)
superset-frontend/src/views/components/SubMenu.tsx 87.50% <77.77%> (-1.87%) ⬇️
superset-frontend/src/views/CRUD/utils.tsx 65.57% <80.00%> (+0.61%) ⬆️
...tend/src/views/CRUD/data/database/DatabaseList.tsx 67.39% <87.50%> (+1.91%) ⬆️
...perset-frontend/src/views/components/MenuRight.tsx 67.69% <100.00%> (+1.97%) ⬆️
...d/src/SqlLab/components/QueryAutoRefresh/index.jsx 61.29% <0.00%> (-22.05%) ⬇️
...rontend/src/explore/components/EmbedCodeButton.jsx 55.00% <0.00%> (-11.67%) ⬇️
...RUD/data/database/DatabaseModal/SqlAlchemyForm.tsx 57.14% <0.00%> (-9.53%) ⬇️
...d/src/SqlLab/components/AceEditorWrapper/index.tsx 44.82% <0.00%> (-8.75%) ⬇️
...ontend/src/components/URLShortLinkButton/index.jsx 93.75% <0.00%> (-6.25%) ⬇️
... and 72 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d53db1...5f01fda. Read the comment docs.

@yousoph
Copy link
Member

yousoph commented Mar 3, 2022

/testenv up

@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2022

@yousoph Ephemeral environment spinning up at http://52.38.37.16:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@yousoph
Copy link
Member

yousoph commented Mar 3, 2022

@pkdotson
Some notes / change requests:

  1. Dropdown text is the wrong color - it should be the same as primary button for both default and hover states. (Caret color is correct though so that doesn't need to change)
  2. The dropdown and the + Database button aren't vertically centered in the header bar. Same issue on the other CRUD pages
  3. Dropdown menu should open on click rather than on hover
  4. The down caret next to the "Upload file to database" text doesn't look vertically centered - it looks too low
  5. Text updates : remove "a" before CSV and Columnar File
  6. Casing update: Should be "Upload a columnar file"
  7. There's something happening with the animation when the dropdown opens that makes it look like it's flashing a bit. There's a blue line that shows for a second
  8. The dropdown alignment looks too high and too close to the text - check the Figma file for reference
    (Is there an existing dropdown component that we can be using here?)

@yousoph
Copy link
Member

yousoph commented Mar 8, 2022

One more text change: should be "Upload Excel file"
Thanks!

@yousoph
Copy link
Member

yousoph commented Mar 9, 2022

/testenv up

@github-actions
Copy link
Contributor

github-actions bot commented Mar 9, 2022

@yousoph Ephemeral environment spinning up at http://34.218.239.39:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@pkdotson pkdotson merged commit d771ddb into apache:master Mar 21, 2022
@github-actions
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

michael-hoffman-26 pushed a commit to nielsen-oss/superset that referenced this pull request Mar 23, 2022
* feat: allow uploads in crud view

* fix merge conflict and fix ts

* fix import

* fix tests

* fix lint

* remove unused var

* fix underline flash and alignment

* fix offset

* fix icon alignment

* fix labels and css issues

* make drowdown primary all the time

* make global

* fix lables

* add upload perms to utils

* remove unused code

* add suggested changes

* update menuright
villebro pushed a commit that referenced this pull request Apr 3, 2022
* feat: allow uploads in crud view

* fix merge conflict and fix ts

* fix import

* fix tests

* fix lint

* remove unused var

* fix underline flash and alignment

* fix offset

* fix icon alignment

* fix labels and css issues

* make drowdown primary all the time

* make global

* fix lables

* add upload perms to utils

* remove unused code

* add suggested changes

* update menuright

(cherry picked from commit d771ddb)
@mistercrunch mistercrunch added 🍒 1.5.0 🍒 1.5.1 🍒 1.5.2 🍒 1.5.3 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels lts-v1 preset-io size/L 🍒 1.5.0 🍒 1.5.1 🍒 1.5.2 🍒 1.5.3 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants